Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix working with non-standard ports #16541

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

dimasites
Copy link
Contributor

@dimasites dimasites commented Mar 22, 2024

Fixed In default config, setup process and setup wizard.

This is port from 2.x branch, all context here: #16455

In default config, setup process and setup wizard
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.57%. Comparing base (e4948f4) to head (ae0364c).
Report is 1 commits behind head on 3.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                3.x   #16541   +/-   ##
=========================================
  Coverage     21.57%   21.57%           
- Complexity    10566    10568    +2     
=========================================
  Files           561      561           
  Lines         31940    31940           
=========================================
  Hits           6892     6892           
  Misses        25048    25048           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@theboxer theboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the port to 3.x

@opengeek opengeek changed the title [3.x] Fix working with non-standart ports Fix working with non-standard ports Mar 25, 2024
@opengeek opengeek added this to the v3.0.5 milestone Mar 25, 2024
@opengeek opengeek merged commit 90e7a46 into modxcms:3.x Mar 25, 2024
7 checks passed
opengeek pushed a commit that referenced this pull request Mar 25, 2024
Fixed In default config, setup process and setup wizard.

This is port from 2.x branch, all context here:
#16455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants