Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize main menu #16530

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

Conversation

Ruslan-Aleev
Copy link
Collaborator

What does it do?

Changed the order of the main menu items.
The items from the "Manage" section have moved to other logically related sections and a new "Access" item has been added and that's it.

What does it look like now:

All menu
menu


Content
content


Extras
extras


Account
user
The language switch is now in the system section. The language switch can be left in "Account" section, but it seems to me that this is more about the "System" than the "Account".


Access
access
All items related to users and access are moved to one section.


System
system_1

system_2

Related issue(s)/PR(s)

Discussed previously in #14855

@Ruslan-Aleev Ruslan-Aleev added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. area-core feature Request about implementing a brand new function or possibility. labels Feb 22, 2024
@Ruslan-Aleev Ruslan-Aleev added this to the v3.1.0 milestone Feb 22, 2024
@Ruslan-Aleev
Copy link
Collaborator Author

I re-opened a previously closed PR; the most useful thing about PR, it seems to me, is a new item for setting up access.

@rthrash
Copy link
Member

rthrash commented Feb 22, 2024

I like the access menu, but to me the language switcher is now too hidden. If I find myself on a site in a language that I’m not familiar with I look for a flag icon or a two-letter language designation somewhere obvious at the top level, not buried behind a menu in a language I can’t read or an icon that doesn’t scream language.

@Ruslan-Aleev
Copy link
Collaborator Author

@rthrash Yes, it’s probably worth returning the language switch to the user section, as it is now.
Although it’s unlikely that the language is switched often in the manager panel. After all, this is a manager panel, not a website.

@rthrash
Copy link
Member

rthrash commented Feb 22, 2024

That’s very fair. I typically switch it on the login page where it is fairly obvious.

@Mark-H
Copy link
Collaborator

Mark-H commented Feb 26, 2024

As far as reviewing this goes, I have no strong opinions on this either way. I'm fine with both the current and the proposed menu structure.

@Ruslan-Aleev
Copy link
Collaborator Author

Yes, I understand that the changes are not critical and can be left as they are.
But I see 2 advantages in the new menu:

  • New separate access menu item;
  • More logical grouping of items. For example, even though I work with MODX every day, I won’t tell from memory where some items are located. With the new structure, I hope this will become more obvious.

@rthrash
Copy link
Member

rthrash commented Apr 16, 2024

I really do like this a lot and think it's a much more logical arrangement. I will get lost looking for the cache clear menu item the first few times, but I'll get used to it quickly. ;) Kudos @Ruslan-Aleev for your thoughtful work and the PR.

@Ruslan-Aleev
Copy link
Collaborator Author

@rthrash Thank you for your kind words and participation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core feature Request about implementing a brand new function or possibility. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants