Fix Element handling from within Categories tree #16493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theboxer
previously approved these changes
Jan 30, 2024
rthrash
added
pr/ready-for-merging
opengeek
added
blocked
opengeek
requested changes
Mar 6, 2024
There was a problem hiding this comment.
Attempting to run the grunt build on this PR fails:
JS_Parse_Error [SyntaxError]: Invalid assignment
at JS_Parse_Error.get (eval at <anonymous> (/Users/opengeek/www/revo-2.x/_build/templates/default/node_modules/uglify-js/tools/node.js:18:1), <anonymous>:71:23)
at formatError (internal/util/inspect.js:1149:38)
at formatRaw (internal/util/inspect.js:919:14)
at formatValue (internal/util/inspect.js:774:10)
at inspect (internal/util/inspect.js:319:10)
at formatWithOptionsInternal (internal/util/inspect.js:1979:40)
at formatWithOptions (internal/util/inspect.js:1861:10)
at console.value (internal/console/constructor.js:328:14)
at console.log (internal/console/constructor.js:364:61)
at /Users/opengeek/www/revo-2.x/_build/templates/default/node_modules/grunt-contrib-uglify/tasks/uglify.js:144:17 {
filename: 'widgets/element/modx.tree.element.js',
line: 213,
col: 29,
pos: 7614
}
Mark-H
reviewed
Mar 11, 2024
| - When creating and Element in the root of it's type's tree: [element type] | ||
| */ | ||
|
|
||
| [extractedData.type] = identifiers; |
There was a problem hiding this comment.
Can a work around be put in place for this so I can get a release out? We are way overdue on a release.
|
Guys, I see what's happening here and on another one of the 2.x builds that's choking (#16467): We'd never updated the template build config like we did for 3.x. Unless there's opposition to doing so, let me go ahead and back port the 3.x setup to 2.x ... then we won't have these issues and won't have to handle code differently between the two branches. |
There's no opposition. Is this something you can get done soon? I'd like to get a release out ASAP. |
opengeek
added a commit
that referenced
this pull request
Mar 21, 2024
### What does it do? Replaces most legacy dependencies with current versions—with the exception of bourbon, neat, and fontawesome—and drops others that are no longer relevant (such as imageoptim). ### Why is it needed? Bring 2.x more in line with 3.x, mainly allow use of modern js features. ### How to test 1. Run the rebuild processes, including `npm update` within the `_build/templates/default` directory. 2. Run `grunt build`. 3. Clear your manager and browser cache, then browse around the manager with your console open to verify all works as expected and no errors are being reported. Note that grunt build will spit out some warnings, as the versions of bourbon and neat we need to stick with here (for now at least) are ancient and contain some long-deprecated code. I attempted to bring these dependencies up to date (including fontawesome) but there are many breaking changes that make it difficult to unwind and get everything working. Might try that later if there's enough "life" left in the 2.x line and it's deemed beneficial to do so. ### Related issue(s)/PR(s) Resolves issues with building after including the following PRs: #16493 and #16467. --------- Co-authored-by: Jason Coward <jason@opengeek.com>
opengeek
changed the title
opengeek
force-pushed
the
2.x-issue-16487
branch
from
44a843c
to
e0938bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a new tree method to properly extract Element data from the working tree Node. There are three patterns for a Node's id, but only one was being accounted for in the code. Additionally, cleans up code formatting in the affected methods.
Why is it needed?
Within the Categories tree, these actions are currently inoperable:
How to test
Related issue(s)/PR(s)
Resolves #16487 for MODX 2.x
Port of PR #16489