Update phpcs.xml to allow non-namespaced classes in select areas #16470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds targeted rule to exclude the PSR1 MissingNamespace error.
Why is it needed?
Two areas of the core—the TV renders and manager controllers—do not declare a namespace in their classes and cause an unfixable code quality error in those files. This is particularly problematic when submitting PRs with changes to those files. Under the assumption that there was good reason to not namespace those files, I opted to adjust the ruleset.
How to test
Simply compare a handful of classes in the noted areas (look at the added rules to see the base paths to those areas) to others in the main core (not components, etc.). Note how the currently non-namespaced classes will not show an error for the rule in question, while ones that do have a namespace will show an error if you delete the namespace declaration.
Related issue(s)/PR(s)
None. Actually was motivated to make the change because my most recent PR (#16469) is failing checks because of the rule issue.