Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix "Form Customization" (Constraint) #16417

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

tanzirev
Copy link

@tanzirev tanzirev commented Apr 8, 2023

In the "Form Customization" tool, in the rule settings, in the "Constraint" field, you can specify multiple ids separated by commas. The rule worked for all fields except TV.

I copied the code from here:
https://github.com/modxcms/revolution/blob/v2.8.4-pl/core/model/modx/modmanagercontroller.class.php#L840

In the "Form Customization" tool, in the rule settings, in the "Constraint" field, you can specify multiple ids separated by commas.
The rule worked for all fields except TV.

I copied the code from here:
https://github.com/modxcms/revolution/blob/v2.8.4-pl/core/model/modx/modmanagercontroller.class.php#L840
@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Apr 8, 2023
@opengeek opengeek added the pr/review-needed Pull request requires review and testing. label Apr 27, 2023
@opengeek opengeek added this to the v2.8.6 milestone Apr 27, 2023
@smg6511
Copy link
Collaborator

smg6511 commented Jun 8, 2023

First, thank you for submitting your first PR!

Please be more specific about

  • what you're entering into the Form Customization Constraints (field and value list)
  • at least some of the changes your making to Regions or Template Variables, and
  • what you're expecting (but not seeing) when editing a Resource that the customization applies to.

It's best to share as much information as you can to make your PRs easier to review ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR. pr/review-needed Pull request requires review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants