[stdlib] Add method unsafe_ptr() to InlineArray
#2642
Closed
+42
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
JoeLoser
approved these changes
May 14, 2024
JoeLoser
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
|
Landed in 31b2e54! Thank you for your contribution 🎉 |
rd4com
pushed a commit
to rd4com/mojo_branch
that referenced
this pull request
May 15, 2024
[External] [stdlib] Add method `unsafe_ptr()` to `InlineArray` This is pretty useful to implement short string optimization. See modularml#2467 Co-authored-by: Gabriel de Marmiesse <gabriel.demarmiesse@datadoghq.com> Closes modularml#2642 MODULAR_ORIG_COMMIT_REV_ID: 5739e8a67742c1841ca3c33efcd23bcc45048b86 Signed-off-by: rd4com <144297616+rd4com@users.noreply.github.com>
lsh
pushed a commit
to lsh/mojo
that referenced
this pull request
May 17, 2024
[External] [stdlib] Add method `unsafe_ptr()` to `InlineArray` This is pretty useful to implement short string optimization. See modularml#2467 Co-authored-by: Gabriel de Marmiesse <gabriel.demarmiesse@datadoghq.com> Closes modularml#2642 MODULAR_ORIG_COMMIT_REV_ID: 5739e8a67742c1841ca3c33efcd23bcc45048b86 Signed-off-by: Lukas Hermann <lukashermann28@gmail.com>
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
[External] [stdlib] Add method `unsafe_ptr()` to `InlineArray` This is pretty useful to implement short string optimization. See modularml#2467 Co-authored-by: Gabriel de Marmiesse <gabriel.demarmiesse@datadoghq.com> Closes modularml#2642 MODULAR_ORIG_COMMIT_REV_ID: 5739e8a67742c1841ca3c33efcd23bcc45048b86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty useful to implement short string optimization. See #2467