-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] implement clear for Dict #2627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request! That should be helpful. There a few small things we could improve and we that should be good to merge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! Do you mind adding a changelog entry here please? Happy to import it and land this internally after that.
Just had one minor comment re a typo as well.
Signed-off-by: Artemio Garza Reyna <artemiogr97@gmail.com>
Signed-off-by: Artemio Garza Reyna <artemiogr97@gmail.com>
@JoeLoser I just modified the changelog and fixed the typo |
!sync |
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
Landed in 22609f3! Thank you for your contribution 🎉 |
[External] [stdlib] Implement `Dict.clear()` Implement `Dict.clear()` to remove all the elements from a `Dict`. ORIGINAL_AUTHOR=artemiogr97 <57588855+artemiogr97@users.noreply.github.com> PUBLIC_PR_LINK=#2627 Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com> Closes #2627 MODULAR_ORIG_COMMIT_REV_ID: 5eaab412c0d7b2a7cde82aecb29b746b7c2d769a
[External] [stdlib] Implement `Dict.clear()` Implement `Dict.clear()` to remove all the elements from a `Dict`. ORIGINAL_AUTHOR=artemiogr97 <57588855+artemiogr97@users.noreply.github.com> PUBLIC_PR_LINK=modularml#2627 Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com> Closes modularml#2627 MODULAR_ORIG_COMMIT_REV_ID: 5eaab412c0d7b2a7cde82aecb29b746b7c2d769a
No description provided.