Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] implement clear for Dict #2627

Closed
wants to merge 2 commits into from

Conversation

artemiogr97
Copy link
Contributor

No description provided.

Copy link
Contributor

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request! That should be helpful. There a few small things we could improve and we that should be good to merge :)

stdlib/test/collections/test_dict.mojo Show resolved Hide resolved
stdlib/src/collections/dict.mojo Outdated Show resolved Hide resolved
Copy link
Contributor

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Do you mind adding a changelog entry here please? Happy to import it and land this internally after that.

Just had one minor comment re a typo as well.

stdlib/src/collections/dict.mojo Outdated Show resolved Hide resolved
Signed-off-by: Artemio Garza Reyna <artemiogr97@gmail.com>
Signed-off-by: Artemio Garza Reyna <artemiogr97@gmail.com>
@artemiogr97
Copy link
Contributor Author

@JoeLoser I just modified the changelog and fixed the typo

@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label May 21, 2024
@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added the merged-internally Indicates that this pull request has been merged internally label May 21, 2024
@modularbot
Copy link
Collaborator

Landed in 22609f3! Thank you for your contribution 🎉

@modularbot modularbot added the merged-externally Merged externally in public mojo repo label May 22, 2024
modularbot added a commit that referenced this pull request May 22, 2024
[External] [stdlib] Implement `Dict.clear()`

Implement `Dict.clear()` to remove all the elements
from a `Dict`.

ORIGINAL_AUTHOR=artemiogr97
<57588855+artemiogr97@users.noreply.github.com>
PUBLIC_PR_LINK=#2627

Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com>
Closes #2627
MODULAR_ORIG_COMMIT_REV_ID: 5eaab412c0d7b2a7cde82aecb29b746b7c2d769a
@modularbot modularbot closed this May 22, 2024
martinvuyk pushed a commit to martinvuyk/mojo that referenced this pull request May 24, 2024
[External] [stdlib] Implement `Dict.clear()`

Implement `Dict.clear()` to remove all the elements
from a `Dict`.

ORIGINAL_AUTHOR=artemiogr97
<57588855+artemiogr97@users.noreply.github.com>
PUBLIC_PR_LINK=modularml#2627

Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com>
Closes modularml#2627
MODULAR_ORIG_COMMIT_REV_ID: 5eaab412c0d7b2a7cde82aecb29b746b7c2d769a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants