Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable domain on alarms, improved password scheme caching #3182

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

Spitfireap
Copy link
Member

  • Made the domain FK for alarms nullable to allow reporting to admins more general issue on the instance
  • Used this to report to admins an issue with the doveadm command
  • Prevented the RQ job from caching the default schemes when the command fails (for permission issue for instance)

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Merging #3182 (d9ee525) into master (699e053) will increase coverage by 0.06%.
Report is 4 commits behind head on master.
The diff coverage is 93.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3182      +/-   ##
==========================================
+ Coverage   82.87%   82.93%   +0.06%     
==========================================
  Files         255      255              
  Lines       12850    12856       +6     
  Branches     1949     1953       +4     
==========================================
+ Hits        10649    10662      +13     
+ Misses       1664     1657       -7     
  Partials      537      537              

@tonioo tonioo merged commit 84d01d4 into master Feb 13, 2024
13 checks passed
@tonioo tonioo deleted the caching-improvement branch February 13, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants