Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gridgen): trap duplicate vertices #1492 #2119

Merged
merged 4 commits into from May 2, 2024

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Mar 4, 2024

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.1%. Comparing base (029a4e1) to head (e62ae32).
Report is 7 commits behind head on develop.

❗ Current head e62ae32 differs from pull request most recent head 79d9bb0. Consider uploading reports for the commit 79d9bb0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2119     +/-   ##
=========================================
+ Coverage     68.3%   73.1%   +4.8%     
=========================================
  Files          260     259      -1     
  Lines        57947   59448   +1501     
=========================================
+ Hits         39611   43503   +3892     
+ Misses       18336   15945   -2391     

see 197 files with indirect coverage changes

@wpbonelli wpbonelli added the bug label May 1, 2024
@wpbonelli wpbonelli changed the title test(gridgen): add test reproducing #1492 fix(gridgen): trap duplicate vertices #1492 May 2, 2024
@wpbonelli wpbonelli marked this pull request as ready for review May 2, 2024 11:23
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this, @wpbonelli.

@wpbonelli wpbonelli merged commit 50bbd01 into modflowpy:develop May 2, 2024
24 checks passed
@wpbonelli wpbonelli deleted the 1492 branch May 2, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DISV model produced by gridgen not converging when original delr/delc contain decimals
2 participants