Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rollupAdapter handling of outside-workspace imports #2727

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

justinfagnani
Copy link
Contributor

Fixes #2231

What I did

  1. Made rollupAdapter correctly take into account rootDir when rewriting outside-of-workspace resolved specifiers.

This PR is a draft because I can't get tests to run locally, and I'm not sure if there's an existing test fixture structure that can express a root dir.

Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: cb050eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/dev-server-rollup Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[commonjs] rootDir causes commonjs modules to resolve incorrectly
1 participant