fix(test-runner-puppeteer): add createBrowserContext
#2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e5551a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dgp1130
force-pushed
the
puppeteer-context
branch
from
22797cd
to
e5551a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
While debugging a
requestAnimationFrameissue (bug coming soon) I discovered that Puppeteer'screateBrowserContextfunction is not implemented despite being clearly documented as supported. I added this function and passed it through to Puppeteer, which seems to be sufficient for it to be used correctly.It doesn't look like the existing tests exercise
puppeteerLauncheroptions, so I didn't add a test here, however in my local testing this function does appear to be called correctly with both theconfigandbrowserand the result is correctly used. I was able to switch Web Test Runner to use an incognito browser with this function.I opted to call this a "fix" because the option is documented to work. However I can also see an argument that this is really a "feature". I'm happy to change that if we feel it is more appropriate.