Split node tests into slow and fast tests #2459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split up the node tests into "slow" and "fast" tests. Fast tests are tests that have a execution time of 25 milliseconds or less and slow tests execute in more than 25 milliseconds. They tests will timeout after 75ms. This change means that the fast test suite runs in roughly 1 second and the slow test suite in 2 minutes.
See
developer-docs/testing-philosophy.mdfor more information on the whole philosophy of this change.I still think there's a lot more we can do to make the tests faster and make the threshold even lower.