Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby3, faraday2 compatibility, remove parse native collection override templates #74

Open
wants to merge 16 commits into
base: feature/1.10.0
Choose a base branch
from
Open

Ruby3, faraday2 compatibility, remove parse native collection override templates #74

wants to merge 16 commits into from

Conversation

brunoenten
Copy link

Minor changes to bring compatibility with ruby 3 and faraday 2. Remove parse native collections models override templates that don't work.

apersaud and others added 16 commits January 11, 2021 12:05
@apersaud
Updated dependencies
1b8bcda
@hspindell
Replaces deprecated Proc.new usage
0128aec 
“warning: Capturing the given block using Proc.new is deprecated; use `&block` instead”
@hspindell
Uses explicit hash argument conversion
4a0f9cf
@hspindell
Updates version + dependencies
7f6b132
@brunoenten
Remove upper bound for dependencies versions
72fb8ef
@brunoenten
Remove extra comma
bb51333
@brunoenten
remove dependence on AMS
08eb6c3
@brunoenten
ignore leading underscore
2d5d0a7
@brunoenten
Merge remote-tracking branch 'origin/feature/proc-warning' into featu…
61d65e8 
…re/1.10.0
@brunoenten
ruby 3.0 compatibility
b475475
@brunoenten
fix block param
7a76ffd
@brunoenten
more ruby 3 compatibility
4cd6356
@brunoenten
faraday 2 compatibility
302900e
@brunoenten
Remove models overrides templates
51fd897 
Can't have two autoloaded files defining the same class. It results in
inconsistent behavior.
Built-in parse classes have to be properly reopened with class_eval.
@brunoenten
compatibility with Rails strong parameters
0e60184
@brunoenten
update doc with reopening builtin classes
f40e6cd
@brunoenten
Copy link
Author

Could you please review?

@jorgeacaballero
Copy link

Faraday2 compatibility is not met while having faraday_middleware as a dependency (see deprecation warning here: https://github.com/lostisland/faraday_middleware) if another project dependency needs faraday2 you will find the following error while bundling

parse-stack was resolved to 1.10.0, which depends on
      faraday_middleware (>= 0.9) was resolved to 0.9.0, which depends on
        faraday (< 0.9, >= 0.7.4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apersaud apersaud apersaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brunoenten @jorgeacaballero @apersaud @hspindell