Don't allow inheriting session if username doesn't match #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MQTT 5.4.2: ".. the implementation should check that the Client is authorized to use the Client Identifier ... to protect against the case where one Client, accidentally or maliciously, provides a Client Identifier that is already being used by some other Client."
|
Ironically the tests failed because they exhibit this bug -- they were using inconsistent usernames between the first and second session. Making the usernames the same fixed the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MQTT 5.4.2: ".. the implementation should check that the Client is authorized to use the Client Identifier ... to protect against the case where one Client, accidentally or maliciously, provides a Client Identifier that is already being used by some other Client."
Fixes #398