kube: controller lifecycle improvements #636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
commented
May 12, 2023
| "os" | ||
| "os/signal" | ||
| "syscall" | ||
| "time" | ||
|
|
||
| "github.com/moby/vpnkit/go/pkg/controller" | ||
| "github.com/moby/vpnkit/go/pkg/vpnkit" | ||
| log "github.com/sirupsen/logrus" |
There was a problem hiding this comment.
logrus was being used in the controller but not here - switched for consistency and to add ability to config log level via flag
* Optimize the `Dockerfile` to use cache mounts
* Use the `context.Context` during HTTP operations
* Add an internal context for normal controller operations
* Sequence shutdown to wait for informer to stop and then
attempt to unexpose any ports before exiting
* Unexpose ports in parallel, we just log out all the
errors regardless
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
force-pushed
the
k8s-forwarder-lifecycle
branch
from
a7e2158
to
e786d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfileto use cache mountscontext.Contextduring HTTP operations