[DO NOT MERGE]: time out connections after 50 minutes #235
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would time out connections after 5 minutes; this patch increases the timeout to 50 minutes as a test. This patch also logs the `Switch.remove` event as "info" so the failure should be more obvious. Related to moby#234 Signed-off-by: David Scott <dave.scott@docker.com>
djs55
added a commit
to djs55/vpnkit
that referenced
this pull request
Aug 10, 2017
Previously we would timeout switch ports after 300s of inactivity. Ideally active connections would be configured to send keep-alive packets sooner than this. To better support cases with no keep-alives, it's useful to be able to reconfigure the idle timeout (e.g. to make it much bigger). This patch adds - a command-line argument `--port-max-idle-time` - a database key `slirp/port-max-idle-time` which allow the default 300s to be overriden. Related to moby#235 Related to moby#234 Signed-off-by: David Scott <dave.scott@docker.com>
djs55
added a commit
to djs55/vpnkit
that referenced
this pull request
Aug 10, 2017
Previously we would timeout switch ports after 300s of inactivity. Ideally active connections would be configured to send keep-alive packets sooner than this. To better support cases with no keep-alives, it's useful to be able to reconfigure the idle timeout (e.g. to make it much bigger). This patch adds - a command-line argument `--port-max-idle-time` - a database key `slirp/port-max-idle-time` which allow the default 300s to be overriden. Related to moby#235 Related to moby#234 Signed-off-by: David Scott <dave.scott@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would time out connections after 5 minutes; this patch
increases the timeout to 50 minutes as a test.
This patch also logs the
Switch.removeevent as "info" so the failureshould be more obvious.
Related to #234
Signed-off-by: David Scott dave.scott@docker.com