Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit test races (carry #48) #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix unit test races (carry #48) #89

wants to merge 1 commit into from
+18 −9

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 19, 2022 •
edited

carries: #48
closes #48

@thaJeztah
Copy link
Member Author

CI failure is unrelated; will be fixed by #90

@thaJeztah
Copy link
Member Author

@dims PTAL 🤗

@dims
Copy link
Collaborator

dims commented Dec 19, 2022

hmm, 90 needs one more approval before we can land that and make this go green here

@dmcgowan @thaJeztah
Fix unit test races
04c4b9a 
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

hmm, 90 needs one more approval before we can land that and make this go green here

I, erm, went slightly ahead and got that one in to fix CI 😅 😇

@dmcgowan ptal

@thaJeztah
Copy link
Member Author

FWIW; I just noticed that #86 also has a fix for this, so we could choose to take that one as well (I guess either approach would work)

@dmcgowan
Copy link
Member

Either is fine, #86 is a bit bigger and think it needs some validation

@aojea
Copy link

aojea commented Feb 14, 2023

/lgtm

I'm going to close #86 since it should no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thaJeztah @dims @dmcgowan @aojea