Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awslogs: Prevent close from being blocked on log #47748

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

awslogs: Prevent close from being blocked on log #47748

wants to merge 1 commit into from
+296 −48

Commits on May 23, 2024

  1. awslogs: Prevent close from being blocked on log 

    Before this change a call to `Close` could be blocked if the the channel
used to buffer logs is full.
When this happens the container state will end up wedged causing a
deadlock on anything that needs to lock the container state.

This removes the use of a channel which has semantics which are
difficult to manage to something more suitable for the situation.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
    @cpuguy83
    cpuguy83 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    ca396df View commit details
    Browse the repository at this point in the history