Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tags.cncf.io/container-device-interface to v0.7.1 #47706

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

elezar
Copy link
Contributor

@elezar elezar commented Apr 10, 2024

This also bumps the maximum supported CDI specification to v0.7.0.

It would also be good to bump this dependency in the 25 release branch.

- What I did

Updated the tags.cncf.io/container-device-interface dependency to v0.7.1. This also updates the supported CDI specification to v0.7.0.

- How I did it
Bumped the go dependenies and ran hack/vendor.sh

- How to verify it

Dependencies are bumped.

- Description for the changelog

Added support for v0.7.0 Container Device Interface (CDI) specifications.

- A picture of a cute animal (not mandatory but encouraged)

vendor.mod Outdated
@@ -78,7 +78,7 @@ require (
github.com/opencontainers/go-digest v1.0.0
github.com/opencontainers/image-spec v1.1.0-rc5
github.com/opencontainers/runc v1.1.12
github.com/opencontainers/runtime-spec v1.1.0
github.com/opencontainers/runtime-spec v1.2.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume that this would be a different PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, I recall I have this one open, which also contains the update; I can move those commits separately;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elezar
Copy link
Contributor Author

elezar commented Apr 15, 2024

I'm happy to hold this until #47719 is completed.

@thaJeztah
Copy link
Member

@elezar #47719 was merged, so you can rebase this one 👍

This also bumps the maximum supported CDI specification to v0.7.0.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the bump-container-device-interface branch from 491114f to 745e235 Compare April 16, 2024 10:18
@elezar
Copy link
Contributor Author

elezar commented Apr 16, 2024

@thaJeztah rebase done.

@elezar elezar requested a review from thaJeztah April 16, 2024 11:03
@thaJeztah thaJeztah added this to the 26.1.0 milestone Apr 16, 2024
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit b7c0598 into moby:master Apr 16, 2024
126 checks passed
@elezar elezar deleted the bump-container-device-interface branch April 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants