Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry host configuration cleanup #47380

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Registry host configuration cleanup #47380

wants to merge 5 commits into from
+1,026 −78

Commits on May 13, 2024

  1. Fork buildkit resolver logic to daemon package 

    This logic is going to be updated to use the new containerd resolver and
needs all the logic handling resolution in the package where it is used.

Signed-off-by: Derek McGowan <derek@mcg.dev>
    @dmcgowan
    dmcgowan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    32443f3 View commit details
    Browse the repository at this point in the history

  2. Update host resolver to use containerd host config 

    Signed-off-by: Derek McGowan <derek@mcg.dev>
    @dmcgowan
    dmcgowan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    34b05f4 View commit details
    Browse the repository at this point in the history

  3. Use daemon config to check for legacy config 

    Use the daemon's configuration to check whether the legacy registry
configuration is used. Only attempt to merge with the legacy
configuration if it has been provided. This avoids merging in based on
a defaulted legacy config.

Signed-off-by: Derek McGowan <derek@mcg.dev>
    @dmcgowan
    dmcgowan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    094b2d8 View commit details
    Browse the repository at this point in the history

  4. Add HTTP fallback to all insecure registries 

    Note that while it is not safe to use http fallback on non-localhost
registries, this can be avoided using the new host directories. The
previous legacy insecure configuration is ambiguous and less secure.

Signed-off-by: Derek McGowan <derek@mcg.dev>
    @dmcgowan
    dmcgowan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e3b7590 View commit details
    Browse the repository at this point in the history

  5. Cleanup legacy mirror string to registry host 

    Move the conversion to its own function and add unit tests.

Signed-off-by: Derek McGowan <derek@mcg.dev>
    @dmcgowan
    dmcgowan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    336126a View commit details
    Browse the repository at this point in the history