Add missing options to bash completion for docker build
#17107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albers
changed the title
docker builddocker build
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
albers
force-pushed
the
completion-build
branch
from
2651891
to
3a713d9
Compare
|
Added this to 1.9.0 milestone (as the command is in there). |
|
LGTM |
| --cgroup-parent | ||
| --cpuset-cpus | ||
| --cpuset-mems | ||
| --cpu-shares -c |
There was a problem hiding this comment.
arg this is on build... we need to remove it from build too :(
EDIT see #17117
There was a problem hiding this comment.
@vdemeester Thanks for taking care of -c.
|
LGTM |
tiborvass
added a commit
that referenced
this pull request
Oct 16, 2015
Add missing options to bash completion for `docker build`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #15182
This adds the new
--build-argand the missing--disable-content-trustto bash completion fordocker build.Hint: the completion of
--build-argis the same as fordocker run -e.As the option lists got too long, I refactored it to use the idioms used in completion for
docker run.Thanks @sdurrheimer for the ping.
As this PR is not trivial, ping @jfrazelle, @tianon for review.