Skip to content

Commit

Permalink
Don't explicitly enable ip6tables in tests
Browse files Browse the repository at this point in the history
Tests no longer need to use "--experimental --ip6tables", now ip6tables
is the default behaviour.

Signed-off-by: Rob Murray <rob.murray@docker.com>
  • Loading branch information
robmry committed Apr 30, 2024
1 parent b28cfd3 commit 8a9f4fb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
10 changes: 4 additions & 6 deletions integration/networking/bridge_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func TestBridgeICC(t *testing.T) {
ctx := setupTest(t)

d := daemon.New(t)
d.StartWithBusybox(ctx, t, "-D", "--experimental", "--ip6tables")
d.StartWithBusybox(ctx, t)
defer d.Stop(t)

c := d.NewClientT(t)
Expand Down Expand Up @@ -276,7 +276,7 @@ func TestBridgeINC(t *testing.T) {
ctx := setupTest(t)

d := daemon.New(t)
d.StartWithBusybox(ctx, t, "-D", "--experimental", "--ip6tables")
d.StartWithBusybox(ctx, t)
defer d.Stop(t)

c := d.NewClientT(t)
Expand Down Expand Up @@ -426,8 +426,6 @@ func TestDefaultBridgeIPv6(t *testing.T) {

d := daemon.New(t)
d.StartWithBusybox(ctx, t,
"--experimental",
"--ip6tables",
"--ipv6",
"--fixed-cidr-v6", tc.fixed_cidr_v6,
)
Expand Down Expand Up @@ -547,7 +545,7 @@ func TestDefaultBridgeAddresses(t *testing.T) {
ctx := testutil.StartSpan(ctx, t)
// Check that the daemon starts - regression test for:
// https://github.com/moby/moby/issues/46829
d.StartWithBusybox(ctx, t, "--experimental", "--ipv6", "--ip6tables", "--fixed-cidr-v6="+step.fixedCIDRV6)
d.StartWithBusybox(ctx, t, "--ipv6", "--fixed-cidr-v6="+step.fixedCIDRV6)

// Start a container, so that the bridge is set "up" and gets a kernel_ll address.
cID := container.Run(ctx, t, c)
Expand Down Expand Up @@ -581,7 +579,7 @@ func TestInternalNwConnectivity(t *testing.T) {
ctx := setupTest(t)

d := daemon.New(t)
d.StartWithBusybox(ctx, t, "-D", "--experimental", "--ip6tables")
d.StartWithBusybox(ctx, t)
defer d.Stop(t)

c := d.NewClientT(t)
Expand Down
2 changes: 0 additions & 2 deletions integration/networking/etchosts_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ func TestEtcHostsIpv6(t *testing.T) {
d := daemon.New(t)
d.StartWithBusybox(ctx, t,
"--ipv6",
"--ip6tables",
"--experimental",
"--fixed-cidr-v6=fdc8:ffe2:d8d7:1234::/64")
defer d.Stop(t)

Expand Down
4 changes: 2 additions & 2 deletions integration/networking/resolvconf_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func TestResolvConfLocalhostIPv6(t *testing.T) {
tmpFileName := network.WriteTempResolvConf(t, "127.0.0.53")

d := daemon.New(t, daemon.WithEnvVars("DOCKER_TEST_RESOLV_CONF_PATH="+tmpFileName))
d.StartWithBusybox(ctx, t, "--experimental", "--ip6tables")
d.StartWithBusybox(ctx, t)
defer d.Stop(t)

c := d.NewClientT(t)
Expand Down Expand Up @@ -78,7 +78,7 @@ func TestInternalNetworkDNS(t *testing.T) {
// Set up a temp resolv.conf pointing at that DNS server, and a daemon using it.
tmpFileName := network.WriteTempResolvConf(t, "127.0.0.1")
d := daemon.New(t, daemon.WithEnvVars("DOCKER_TEST_RESOLV_CONF_PATH="+tmpFileName))
d.StartWithBusybox(ctx, t, "--experimental", "--ip6tables")
d.StartWithBusybox(ctx, t)
defer d.Stop(t)

c := d.NewClientT(t)
Expand Down

0 comments on commit 8a9f4fb

Please sign in to comment.