RFC: Removed the default set PATH for Windows environments. #4895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is related to this PR: Don't set a default PATH for Windows.
Description:
This change seeks to remove the defaulted Windows image path found in util\system\path.go.
I used buildkit to create two images with following docker file contents:
For one image the PATH in util\system\path.go is defaulted to "c:\Windows\System32;c:\Windows" while for the other image the PATH is defaulted to an empty string.
In mcr.microsoft.com/windows/servercore:ltsc2022, PowerShell is available in "C:\Windows\System32\WindowsPowerShell\v1.0". When the PATH is defaulted to a specific value, application files for applications like PowerShell cannot be found/referenced hence the need to remove the defaulted path.