Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobx-react-lite): fix double component rendering due to empty getServerSnapshot #3830

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

dmitrytavern
Copy link
Contributor

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (yarn mobx test:performance)

Fixes #3826
Fixes double rendering of component due to difference of snapshot values in getSnapshot() and getServerSnapshot() on initial rendering.

Copy link

changeset-bot bot commented Feb 13, 2024

🦋 Changeset detected

Latest commit: 98c5b77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx-react-lite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@urugator urugator merged commit b970cbb into mobxjs:main Feb 14, 2024
1 check passed
@urugator
Copy link
Collaborator

Thank you!

@github-actions github-actions bot mentioned this pull request Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mobx-react-lite component wrapped in observer renders twice in latest Next.js
2 participants