Unset stale SSH_TTY environment variable #1187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable would confuse devices that relied on it, such as the Clipetty extension for Emacs. See issue mobile-shell#1134
|
This environment variable may also interfere with other commands that check if they are being run within a SSH session (ie, https://github.com/theimpostor/osc). Because the SSH_TTY dies with the SSH command, it does not make sense for mosh to inherit it. I tried to remove this on the client side when calling mosh-server, but the result was not portable. The patch is consistent with the previous "STY" unset. Is there anything I can do to help merge this? |
|
+1 for merging this. Please give some explanation if you don't want to merge this and close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable would confuse devices that relied on it, such as the Clipetty extension for Emacs. See issue #1134.
Tested on my end, I can now use Clipetty without needing to detect Mosh's existence and unset the variable manually. LMK if I did anything incorrectly.