Add support for ECMA-48 escape sequences for faint/half-bright and crossed-out/strikethrough #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2019 20:10
ECMA-48 defines rendition mode 2 as: faint, decreased intensity or second colour Faint mode shares its inverse (22) with bold (1): normal colour or normal intensity (neither bold nor faint) The Renditions::attribute_type enum already included 'faint' but the value remained unused until now. Signed-off-by: Stanislav Spassov <stanspas@amazon.de>
ECMA-48 defines rendition mode 9 as: crossed-out (characters still legible but marked as to be deleted), and mode 29 as the inverse: not crossed out Modern terminals (including xterm, tmux, libvte, etc.) support rendering strikethrough. Further, ncurses since version 6.1 includes the smxx/rmxx user-defined terminal capabilities in the tmux and xterm-basic databases. Note that the new attribute still fits in the eight bits allocated for Renditions::attributes, so there is no need to increase the size of Cell. Signed-off-by: Stanislav Spassov <stanspas@amazon.de>
|
What needs to be added or changed before this can be merged? It's a trivial change, it works, and it's a feature I'd really like to have. I'm currently patching mosh on several machines by hand, because a program uses faint text, which mosh does not yet support. It would support it with this PR. I've checked the resources, and the ANSI escape sequences used in these commits are correct, including the dual functionality of 22 which unsets both dim and bold. Please consider merging this PR. If any further work is needed, I might be willing to do it. But from the looks of it, it looks very correct and complete. |
jdrouhard
added a commit
to jdrouhard/mosh
that referenced
this pull request
May 20, 2023
Add support for ECMA-48 escape sequences for faint/half-bright and crossed-out/strikethrough
jdrouhard
added a commit
to jdrouhard/mosh
that referenced
this pull request
Aug 20, 2023
|
Updated with new formatting here too: https://github.com/blinksh/mosh-server/tree/dim-and-strikethrough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.