animate_topomap - CSD fix #12605
Merged
animate_topomap - CSD fix #12605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
agramfort
reviewed
May 8, 2024
There was a problem hiding this comment.
looks clean ! thx @michalrzak
can you update the changelog to make the CI green? thx
larsoner
approved these changes
May 15, 2024
There was a problem hiding this comment.
Moved the imports and removed now unnecessary plt.close("all")s that I saw as well, marking for merge when green. Thanks in advance @michalrzak !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Example: Fixes #12599.
What does this implement/fix?
For a detailed explanation, please refer to the associated issue.
In essence, this PR addresses the issue where
animate_topomap()fails to function with "csd" data. The proposed solutions in the issue include a straightforward addition of "csd" to the list of permittedch_typesforanimate_topomap, as well as a more intricate approach that consolidates thech_typeselections from bothanimate_topomap()andplot_evoked_topomap().This PR implements the latter solution, as I find it to be the more comprehensive approach. However, I may have missed a specific reason for maintaining different channel selections in
animate_topomap()andplot_evoked_topomap(). Should such reasons exist, I am open to adjusting this PR accordingly.