STY: Apply ruff/flake8-implicit-str-concat rule ISC001 #12602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
ISC001
branch
3 times, most recently
from
4a7c75d
to
070ab62
Compare
DimitriPapadopoulos
requested review from
larsoner,
drammock,
agramfort,
dengemann,
wmvanvliet,
adam2392,
mscheltienne,
alexrockhill,
hoechenberger,
jasmainak,
cbrnr,
sappelhoff and
rob-luke
as code owners
ISC001 Implicitly concatenated string literals on one line This rule is currently disabled because it conflicts with the formatter: astral-sh/ruff#8272
ISC001 Implicitly concatenated string literals on one line This rule is currently disabled because it conflicts with the formatter: astral-sh/ruff#8272
DimitriPapadopoulos
force-pushed
the
ISC001
branch
from
070ab62
to
c3296bc
Compare
DimitriPapadopoulos
changed the title
mscheltienne
approved these changes
May 5, 2024
|
Haha oh my, didn't we try to fix hundreds of these manually just recently? @cbrnr @larsoner 😅😅😅 Great you found this rule, @DimitriPapadopoulos! |
|
To tell the truth, I did have to change ~50 occurrences manually because ruff currently cannot fix cases such as I would recommend you double-check the last commit. |
|
Thanks @DimitriPapadopoulos ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
What does this implement/fix?
Additional information
This rule is currently disabled because it conflicts with the formatter:
astral-sh/ruff#8272
This probably doesn't require an entry in the changelog, does it?