Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MNE-ICALabel #812

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Nov 7, 2023

Before merging …

  • Changelog has been updated (docs/source/changes.md)

pyproject.toml Outdated Show resolved Hide resolved
@hoechenberger
Copy link
Member Author

@larsoner I'm not sure why this one test fails, could you help me out here please? :)
https://github.com/mne-tools/mne-bids-pipeline/actions/runs/6798018175/job/18481346112?pr=812

@hoechenberger
Copy link
Member Author

hoechenberger commented Nov 8, 2023

@larsoner
Copy link
Member

larsoner commented Nov 8, 2023

It only looks for items that are ast.AnnAssign so it's because you did not type annotate. I added a test that will check this more explicitly and fixed the error

@hoechenberger
Copy link
Member Author

Thanks @larsoner!!

@larsoner
Copy link
Member

larsoner commented Nov 8, 2023

Also @hoechenberger we are almost through all of our 250,000 paid CircleCI compute credits for Nov mostly from MNE-BIDS-Pipeline usage (141,856 MBP vs 46,692 for MNE), so if there is any way you could push less often and do more local testing it would be greatly appreciated 🙏

@hoechenberger
Copy link
Member Author

Argh ok will try

@behinger
Copy link

hey! I tried to merge the newest changes in mne_bids_pipeline into this branch to make use if icalabel - but it is more tricky than anticipated because quite some code got moved around and I am not familiar with the code-base.

Any chance you have some newer local version already merged? If not, I will dig deeper into the code-base

Cheerio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants