Added support for Google Analytics 4 Properties. Removed duplication of Javascript snippets. #429
+96
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lytics' on the bottom of each page
|
Based on the sample code I am currently seeing on my Analytics account, there seems to no longer be any need for different javascript depending on the analytics version used, so this can be further simplified (I am looking at a gtag-based snippet using a "UA-" tag). |
|
UA tags will cease to work on July 1, 2023. Until then, both tags need to be supported. |
leewc
approved these changes
Apr 11, 2023
leewc
approved these changes
Apr 11, 2023
leewc
added a commit
to leewc/leewc.github.io
that referenced
this pull request
Apr 11, 2023
Main repo that this is forked from does not appear to be maintained. Referenced mmistakes/so-simple-theme#429
leewc
added a commit
to leewc/leewc.github.io
that referenced
this pull request
Apr 11, 2023
Main repo that this is forked from does not appear to be maintained. Referenced mmistakes/so-simple-theme#429
leewc
added a commit
to leewc/leewc.github.io
that referenced
this pull request
Apr 11, 2023
Main repo that this is forked from does not appear to be maintained. Referenced mmistakes/so-simple-theme#429
|
@mmistakes can we get this merged please? |
…n about what's actually been published
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement or feature.
Summary
The old Google Analytics uses codes of the form UA-XXXXX. The new Google Analytics uses codes of the form G-XXXXX and they have different javascript snippets that need to be used for each. This PR adds support for the G- style codes.
Also previously the javascript for the UA codes was in two places and it's now in one.
Context