Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add link to Datastore #5559

Merged
merged 4 commits into from
May 19, 2024
Merged

[Docs] Add link to Datastore #5559

merged 4 commits into from
May 19, 2024

Conversation

jillnogold
Copy link
Member

fix order

@jillnogold jillnogold requested a review from assaf758 May 13, 2024 10:52
assaf758
assaf758 reviewed May 13, 2024
View reviewed changes
Copy link
Member

@assaf758 assaf758 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment:
I suggest to keep "OSS", as it's a known name in the industry (like "S3")

docs/store/datastore.md Outdated Show resolved Hide resolved
docs/store/datastore.md Outdated Show resolved Hide resolved
@assaf758 assaf758 merged commit f4eb37a into mlrun:development May 19, 2024
11 checks passed
@jillnogold jillnogold deleted the datastore-minor-fixes branch May 19, 2024 13:24
rokatyy pushed a commit to rokatyy/mlrun that referenced this pull request May 28, 2024
@jillnogold @rokatyy
[Docs] Add link to Datastore (mlrun#5559)
e44d84b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assaf758 assaf758 assaf758 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jillnogold @assaf758