Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Projects] Add Iguazio version validation for adding node selector to project #5522

Open
wants to merge 17 commits into
base: development
Choose a base branch
from
Open

[Projects] Add Iguazio version validation for adding node selector to project #5522

wants to merge 17 commits into from

Conversation

yaelgen
Copy link
Collaborator

@yaelgen yaelgen commented May 6, 2024 •
edited

Adds a check for the Iguazio version before applying the default_function_node_selector to project attributes to ensures backwards compatibility.

  • Introduce getter/setter methods for default_function_node_selector.
  • Add check for the Iguazio version when transforming mlrun project to iguazio project

resolves: ML-6316

alonmr
alonmr requested changes May 20, 2024
View reviewed changes
Copy link
Member

@alonmr alonmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some small comments

mlrun/utils/helpers.py Outdated Show resolved Hide resolved
tests/api/utils/clients/test_iguazio.py Outdated Show resolved Hide resolved
server/api/utils/clients/iguazio.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonmr alonmr alonmr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yaelgen @alonmr