Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] improve job resources page #5459

Merged
merged 15 commits into from May 20, 2024

Conversation

jillnogold
Copy link
Member

No description provided.

@jillnogold jillnogold requested a review from alonmr May 7, 2024 11:09
Copy link
Member

@alonmr alonmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick scan and here are a few comments for starters

docs/runtimes/configuring-job-resources.md Outdated Show resolved Hide resolved
docs/runtimes/configuring-job-resources.md Outdated Show resolved Hide resolved
docs/runtimes/configuring-job-resources.md Outdated Show resolved Hide resolved
docs/runtimes/configuring-job-resources.md Outdated Show resolved Hide resolved
docs/runtimes/configuring-job-resources.md Outdated Show resolved Hide resolved
docs/runtimes/configuring-job-resources.md Outdated Show resolved Hide resolved
docs/runtimes/configuring-job-resources.md Outdated Show resolved Hide resolved
Copy link
Member

@alonmr alonmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small comments

docs/runtimes/configuring-job-resources.md Outdated Show resolved Hide resolved
docs/runtimes/configuring-job-resources.md Outdated Show resolved Hide resolved
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@alonmr alonmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor

docs/runtimes/configuring-job-resources.md Outdated Show resolved Hide resolved
docs/runtimes/configuring-job-resources.md Outdated Show resolved Hide resolved
docs/runtimes/configuring-job-resources.md Outdated Show resolved Hide resolved
@alonmr alonmr merged commit 8ce4e48 into mlrun:development May 20, 2024
11 checks passed
@jillnogold jillnogold deleted the improve-node-selection branch May 20, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants