Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linting] Add pre-commit #4951

Open
wants to merge 13 commits into
base: development
Choose a base branch
from
Open

[Linting] Add pre-commit #4951

wants to merge 13 commits into from
+41 −23

Conversation

jond01
Copy link
Member

@jond01 jond01 commented Jan 17, 2024 •
edited

@jond01 jond01 requested a review from gtopper January 17, 2024 11:20
gtopper
gtopper reviewed Jan 18, 2024
View reviewed changes
Makefile Show resolved Hide resolved
gtopper
gtopper reviewed Jan 18, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
gtopper
gtopper reviewed Jan 18, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
liranbg
liranbg reviewed Jan 18, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@gtopper gtopper mentioned this pull request Jan 21, 2024
Closed
@jond01 jond01 marked this pull request as ready for review January 21, 2024 12:51
gtopper
gtopper approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@gtopper gtopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! ✅

@jond01 jond01 marked this pull request as draft January 25, 2024 08:58
@jond01 jond01 marked this pull request as ready for review February 4, 2024 09:54
@jond01 jond01 mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtopper gtopper gtopper approved these changes

@liranbg liranbg Awaiting requested review from liranbg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jond01 @gtopper @liranbg