-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation - Find and Fill Method for Dropout Layer #3684
Open
MarkFischinger
wants to merge
7
commits into
mlpack:master
Choose a base branch
from
MarkFischinger:feat/fill_and_fill_implemenation
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f2660a7
feat: updated Dropout Forward with find and fill
MarkFischinger cf6aa30
Merge branch 'mlpack:master' into feat/fill_and_fill_implemenation
MarkFischinger 65e9914
struct: implemented both versions of the algorithm
MarkFischinger 7511561
fixed structure
MarkFischinger 20cf02e
refactor dropout layer implementation
MarkFischinger 862c05e
fix
MarkFischinger 52b6e29
remove line break
MarkFischinger File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -74,10 +74,18 @@ DropoutType<MatType>::operator=(DropoutType&& other) | |||
return *this; | ||||
} | ||||
|
||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
No need for an extra line 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, this one is still missing. |
||||
template<typename MatType> | ||||
void DropoutType<MatType>::Forward(const MatType& input, MatType& output) | ||||
{ | ||||
// The dropout mask will not be multiplied in testing mode. | ||||
ForwardImpl(input, output); | ||||
} | ||||
|
||||
template<typename MatType> | ||||
template<typename T, typename std::enable_if_t<arma::is_arma_type<T>::value, int>> | ||||
void DropoutType<MatType>::ForwardImpl(const T& input, T& output) | ||||
{ | ||||
if (!this->training) | ||||
{ | ||||
output = input; | ||||
|
@@ -92,6 +100,22 @@ void DropoutType<MatType>::Forward(const MatType& input, MatType& output) | |||
} | ||||
} | ||||
|
||||
template<typename MatType> | ||||
template<typename T, typename std::enable_if_t<!arma::is_arma_type<T>::value, int>> | ||||
void DropoutType<MatType>::ForwardImpl(const T& input, T& output) | ||||
{ | ||||
if (!this->training) | ||||
{ | ||||
output = input; | ||||
} | ||||
else | ||||
{ | ||||
mask.randu(input.n_rows, input.n_cols); | ||||
mask = (mask > ratio); | ||||
output = input % mask * scale; | ||||
} | ||||
} | ||||
|
||||
template<typename MatType> | ||||
void DropoutType<MatType>::Backward( | ||||
const MatType& /* input */, | ||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarkFischinger
Looks better, just use directly
MatType
instead ofT
. It is better for readability becauseT
does not mean a lot.Also, could you break the line? mlpack code base is usually under 80 lines of code.
Also, the syntax is correct, I would remove
int
and instead add a*
after>
so the signature looks as follows:The reason for this is to have the same signature over all the code base, making it easier for everyone.