Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecisionTree documentation - NoRecursion flag #3674

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

TirelessClock
Copy link
Contributor

Noticed a few faults in the DecisionTree and DecisionTreeRegressor documentation related to the NoRecursion flag:

  • In the code it has been defaulted to false
    Screenshot 2024-03-30 222928
    Screenshot 2024-03-30 222955

but in the documentation it said defaulted to true

  • NoRecursion=false implies that it will be a full Decision Tree, and NoRecursion=true implies that it will be a stump, but it's the opposite in the documentation.

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's the problem with negatives in variable names... I got it backwards when I documented it. I appreciate the fix 👍

Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@rcurtin rcurtin merged commit e3cd78a into mlpack:master Apr 1, 2024
17 of 20 checks passed
@TirelessClock TirelessClock deleted the documentation branch May 15, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants