Fix STB detection when STB is manually specified #3660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered while debugging #3641 that CMake was not actually configuring mlpack as though STB was available, even though STB's location was being specified in the CMake call! Digging into this, I found that our CMake code was using the
STB_IMAGE_FOUND
variable, but the scriptCMake/FindStbImage.cmake
doesn't always set that variable.The correct variable to use is actually
StbImage_FOUND
, which is set by thefind_package_handle_standard_args()
CMake function. So, I adapted our CMake configuration to use that instead, and removed the manually-setSTB_IMAGE_FOUND
variable, which actually will not be set when a user manually specifies the STB include directory.