-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Dockerfile for codespaces... #30
base: master
Are you sure you want to change the base?
Initial Dockerfile for codespaces... #30
Conversation
Welp, this isn't minimal at all in terms of the base image. Building onto the container with just a few items causes the image to exceed what's available on GH Action Builder to create a modified image. Plus, I can't build the image locally due to it rejecting So, my thought here is to move away from the universal as a base image or lobotomize the container of https://github.com/devcontainers/images/blob/main/src/universal/history/2.9.0.md There are other containers, but we're stuck with a container that uses the Universal ID if we want it to work 👎 . Any preference @rcurtin ? |
Do you think I could build it locally and push it? It's ok with me if each container needs to be handbuilt and pushed to Dockerhub to be updated---that's already what we do for containers when mlpack versions get bumped. Happy to try it. I do have an OS X arm64 (M1 or M2, can't remember) system I could use to build that version. |
So, the hiccup building locally was the base universal is docker buildx build --platform=linux/amd64 -t mlpack-codespace . I'll have time to check the image later today that this |
Awesome! If that works, I can push it to the mlpack Dockerhub account too. |
libblas-dev \ | ||
libarpack2 \ | ||
libsuperlu-dev \ | ||
libstb-dev && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will also need libcereal-dev
, unless that's already installed. 👍
pandas setuptools | ||
|
||
## Install armadillo. | ||
RUN curl -Lk https://files.mlpack.org/armadillo-11.4.1.tar.gz | tar -xvz && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to put a newer version in place if you like.
I've tried to keep this
Dockerfile
as minimal as possible. The target for the container is to quickly bootstrap contributing tomlpack
via GitHub Codespaces.Unlike the
mlpack/mlpack
and other containers in the repository, we're building this off of the universal devcontainer to lower the storage requirements associated with deployment on GitHub Codespaces following the "Getting the most out of your included usage".