-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab navigation custom behaviours #932
base: dev
Are you sure you want to change the base?
Conversation
~ Change default behaviour to `.system`.
~ Change default to `.primary`.
Co-authored-by: Eric Andrews <eric.b.andrews.auto@protonmail.com>
~ Change default behaviour to `.system`.
~ Change default to `.primary`.
- Rename actions. - Add icon to settings row.
I think the wording here could be improved somewhat. Would an inline list picker give us more space (the one with the checkmarks)? Maybe it could be titled "Tap tab bar icon to..." or "When I tap the tab bar icon..." and have the following options:
|
Yea, that could work better, will tweak and update |
Looks good! I think it might look a little better in Title Case, without the trailing ellipses? |
We might want to move all the tab bar stuff into its own section of Settings--with this PR we're going to have:
Certainly not a blocker to this PR though |
That could work. What about the other categories? There are other cases where we will have a similar split-up grouping in future. An example would be when we add swipe action customisation, which in our current layout would go inside of a new "Gestures" page. That splits them up from the interaction bar customisation, which feels slightly off to me. And what if we then add ellipsis menu customisation too? Where would that go? It would be strange to put that in Appearance. One solution go the proposed tab-bar settings route for the other categories too, and simply put all of the navigation links that are currently under Appearance under the root view. Then, gestures and ellipsis menu customisation could go in the same menu as appearance settings. |
Both work, I chose the ellipses without title case to indicate that there's more to the action than the literal name (i.e. nudge users to read the footer text lol) |
Yea, tab bar stuff definitely needs its own little page soon with the hide tab bar on scroll feature (going to wait for v2.0), and also thinking about long press to scroll to top (also going to wait for v2.0). |
Re: menu names--these behaviors are super complex to describe in a single list entry. Ellipsis + footer works well enough for me as a pro tem solution, but longer term we might want to look into using animations to describe the behavior the way we do with the quick switcher |
Yea, eventually animations, figured I'd get this in without them for now because of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Works pretty much perfectly. I found a couple minor defects while testing:
- Scroll to Top does not behave properly in Community view
- Do Nothing still scrolls to top in Feeds view
0834c01
to
e506ba1
Compare
Pull Request Information
About this Pull Request
Allows users to customize tab bar actions behaviour:
Appreciate any input on behaviour naming and explanation text.
Screenshots and Videos