Color Profiles #1058
Merged
Color Profiles #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBAndrews
requested review from
mormaer and
ShadowJonathan
and removed request for
a team
Sjmarf
requested changes
May 11, 2024
Co-authored-by: Sjmarf <78750526+Sjmarf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- groundwork for Comment bar color themes #803, Themes #252
Pull Request Information
This PR adds support for app-wide color profiles. A new protocol,
PaletteProviding, defines the set of color definitions that constitute a color profile. In this PR, two profiles are implemented:StandardPaletteandMonochromePalette. Propagating palette information to the app is handled by the globalPaletteobject, which is itselfPaletteProvidingand operates according to the standard pattern for makingany Protocolconcrete.I've only defined colors that we're currently using, on the theory that it will be pretty easy to add colors as we need them. I've opted for semantic rather than literal colors, which will make the protocol a little larger but should give us better flexibility for themes. At some point we're presumably going to need literal colors for things like settings squircles.
This PR also updates CONTRIBUTING.md per Slack