Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription List #1052

Merged
merged 19 commits into from
May 11, 2024
Merged

Subscription List #1052

merged 19 commits into from
May 11, 2024

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented May 5, 2024

Added a SubscriptionList model to MlemMiddleware (see this PR) to keep track of subscriptions and favorites. The subscription list is stored weakly in the ApiClient so that it can be accessed by children of the client. When .toggleSubscribe or .toggleFavorite is called on a Community model, the changes are state-faked in the SubscriptionList. Favorites aren't stored in a file yet, so won't be kept if you close the app.

The "Profile" tab includes a basic subscription list UI for testing purposes.

Closes #1051

@Sjmarf Sjmarf requested a review from a team as a code owner May 5, 2024 17:51
@Sjmarf Sjmarf requested review from mormaer and ShadowJonathan and removed request for a team May 5, 2024 17:51
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Sjmarf Sjmarf merged commit 06ed65e into dev2 May 11, 2024
1 check passed
@Sjmarf Sjmarf deleted the sjmarf/dev2-subscription-list branch May 11, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants