Added filtering option for entities listing #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VukW
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
VukW
commented
Nov 27, 2023
| @@ -5,15 +5,14 @@ | |||
| class Entity(ABC): | |||
| @abstractmethod | |||
| def all( | |||
| cls, local_only: bool = False, comms_func: callable = None | |||
| cls, local_only: bool = False, filters: dict = None | |||
There was a problem hiding this comment.
This fix was not connected to ls valid feature, just a bugfix: making abstract function signature relevant to a real implementations
VukW
commented
Nov 27, 2023
| @@ -105,3 +106,6 @@ def default_status(cls, v): | |||
| if v is not None: | |||
| status = Status(v) | |||
| return status | |||
|
|
|||
| class DeployableEntity(DeployableSchema, Entity): | |||
| pass | |||
There was a problem hiding this comment.
This "implementation" is necessary at two places:
- Entity list command - to declare that applicable objects should be both DeployableSchema and Entity.
- for Entity list test purposes
However, placing implementation here breaks code design a bit: it makeschemas.pydependable frominterface.py. Maybe it's worth to move this class definition to other place?
VukW
commented
Nov 27, 2023
|
|
||
| # generate_cube(id=103, is_valid=True, owner=12345), | ||
| # generate_cube(id=104, is_valid=False, owner=12345), | ||
| ] |
There was a problem hiding this comment.
The current behavior is not to filter local cubes by owner. I didn't change it, instead I anchored it in this test case. In future, once we elaborate & implement new ls behavior, these tests have to be changed
VukW
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for #496 : add
--validflag for entity listing:Waits for #509 to implement
is_validflag forResultentity