Windows compatibility #417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
…o windows-support
hasan7n
reviewed
Apr 24, 2023
hasan7n
reviewed
Apr 24, 2023
| @@ -1,18 +1,20 @@ | |||
| typer~=0.6.0 | |||
| typer~=0.6.0; sys_platform != "win32" | |||
| typer<0.5.0; sys_platform == "win32" | |||
| rich~=12.5.0 | |||
| PyYAML>=5.4,<6 | |||
| requests>=2.26.0 | |||
| pydantic==1.10.2 | |||
| yaspin==2.1.0 | |||
| tabulate==0.8.9 | |||
| pexpect==4.8.0 | |||
There was a problem hiding this comment.
do we need this for windows?
There was a problem hiding this comment.
here I meant to refer to pexpect
hasan7n
requested changes
Apr 25, 2023
There was a problem hiding this comment.
Great work Alejandro, thanks! A couple of points:
- Let's add Windows OS for the workflow runner configuration. Do we need to contact administrators about this before?
- Since singularity is not supported in Windows, do we have an informative message when someone tries to use
--platform singularityon Windows? - I am a bit concerned about using
wexpect.pexpectmentions it but says that it is unmaintained. I wonder if we can later see an alternative (even maybe an alternative topexpect?)
Co-authored-by: hasan7n <78664424+hasan7n@users.noreply.github.com>
|
the only todo: workflow for windows |
hasan7n
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
hasan7n
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
hasan7n
had a problem deploying
to
testing-external-code
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CThis PR applies the necessary changes to provide support for Windows machines. It does so by adjusting requirements, updating the MLCube packages, and providing additional logic if necessary. Closes #363.