Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETFeeder] Speedup et_feeder and resolve uninitialized attrs values in ETFeederNode #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[ETFeeder] Speedup et_feeder and resolve uninitialized attrs values in ETFeederNode #7

wants to merge 2 commits into from

Conversation

changhai0109
Copy link
Contributor

  1. Updated ETFeeder::readNextWindow to speed up by removing some extra resolveDeps() calls.
  2. Assigned default values of attrs in ETFeederNode to avoid uninitialized variables and leading undefined behavior with -O3 compile flag.

@changhai0109 changhai0109 requested a review from a team as a code owner December 12, 2023 00:02
@changhai0109 changhai0109 changed the title Changhai speedup etfeeder [ETFeeder] Speedup et_feeder and resolve uninitialized attrs values in ETFeederNode Dec 12, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@changhai0109
Copy link
Contributor Author

@mlcommons/wg-chakra

Hi, ppl, for PR #7, #8, #9, #10, and #11, they have been stalled for weeks.

Is there any blocker preventing merging them? Please leave any comments if there are any concerns about these PRs. Thanks!

@JoongunPark
Copy link
Contributor

JoongunPark commented Feb 6, 2024 •
edited

Those two commits look good to me!
@changhai0109
Thank you for the PR.
We've got minor a conflict in ET_Feeder. Could you solve that please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoongunPark JoongunPark Awaiting requested review from JoongunPark

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@changhai0109 @JoongunPark