Support Any type in AttributeProto #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
Thank you for your contribution, Andy!
|
TaekyungHeo
changed the title
|
@TaekyungHeo I've updated the summary to include the rationale behind the any type. |
|
@ajbalogh - repeating a question @TaekyungHeo already asked... if Any is a native type, why do we need to import the type? |
|
@srinivas212 @TaekyungHeo - Any isn't a native type but a standard protobuf definition that is included with the protobuf installation and as result requires it to be imported. |
|
@srinivas212 , I think @ajbalogh 's point makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the Any type to the AttributeProto message as a single any_val and repeated any_list.
The Any type in Any.proto is a standard Protobuf definition included with the Protobuf installation.
The rationale behind this is that a user wants to use complex protobuf messages for metrics and configuration and add them to individual et_def.Node messages.
The any_val field in AttributeProto allows a user to easily serialize/deserialize messages into a single field while preserving the structure of the message and associated internal documentation and options.