Skip to content

Commit

Permalink
Fixing cicd (#929)
Browse files Browse the repository at this point in the history
dask <= 2024.4.0 is incompatible with python 3.11.9. Github updated
there runners and our cicd pipelines were failing.
A fix was released as part of dask 2024.4.1, however we can not use this
version since there are dependency conflicts with dask-cuda.

<s>Limited our python version to <3.11.9</s>

**Update 16/04/24:** 
We encountered `TypeError "<" not supported between instance of 'int'
and 'str'`. This is related to sorting operation part of `dask-expr`.
dask-expr is part of `dask>=2024.3.0`. Dask supports a specific
configuration to disable the computation graph optimizations and the
usage of dask-expr. However, limit the dask version to `dask<2024.3.0`
would avoid further issues since we have tested these version before.
  • Loading branch information
mrchtr committed Apr 17, 2024
1 parent c8aa2b2 commit 1b33535
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v1
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jsonschema = ">= 4.18"
pyarrow = ">= 11.0.0"
pyyaml = ">= 5.3.1"

dask = { version = ">= 2023.4.1", extras = ["dataframe", "distributed", "diagnostics"]}
dask = { version = ">= 2023.4.1, <2024.3.0", extras = ["dataframe", "distributed", "diagnostics"]}
docker = ">= 6.1.3"

dask-cuda = { version = ">=23.4.1", optional = true }
Expand Down

0 comments on commit 1b33535

Please sign in to comment.