Develop #5
Open
Develop #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impruve sample and add new make targets make test with sample get about 70% tcov
prevent all warnings added sample/sample.cpp and sample/Makefile to test ca 70% of code (tcov)
|
Thanks you for the PR. This is quite a lot, i'll try to review it tomorrow. |
|
Any update / news on this one? |
|
ouch, completely forgot about that one. I started looking into the PR and noticed that there were a lot of distinct things bundled in that patch (which i'd have to test separately), so i'd have to to untangle things first and shelved it for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for ipv6 support