Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dart:ui import error #64

Closed
wants to merge 1 commit into from

Conversation

chooyan-eng
Copy link
Contributor

Status

READY

Description

Importing dart:ui is missing and results in the error below.

../../../.pub-cache/hosted/pub.dev/flutter_deck-0.11.1/lib/src/widgets/flutter_deck_footer.dart:96:38: Error: Undefined name 'FontFeature'.
                fontFeatures: const [FontFeature.tabularFigures()],
                                     ^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/flutter_deck-0.11.1/lib/src/widgets/flutter_deck_footer.dart:96:50: Error: Method invocation is not a constant expression.
                fontFeatures: const [FontFeature.tabularFigures()],
                                                 ^^^^^^^^^^^^^^
Target kernel_snapshot failed: Exception

Command PhaseScriptExecution failed with a nonzero exit code
** BUILD FAILED **

One thing I'm curious about is that I could run last week with 0.11.1 and I can't now with 0.12.0 even though this class has no change between 0.11.1 and 0.12.0. In addition, the error now happens even with 0.11.1.

I just stopped taking a closer look at it and just added one line to import.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ› οΈ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • βœ… Build configuration change
  • πŸ“ Documentation
  • πŸ—‘οΈ Chore

@chooyan-eng
Copy link
Contributor Author

chooyan-eng commented Mar 4, 2024

It seems dart:ui is included in material.dart and explicit import is unnecessary.
I guess the issue is environment-specific of my project, so I'll just close this PR.

@chooyan-eng chooyan-eng closed this Mar 4, 2024
@mkobuolys
Copy link
Owner

This import is not needed with Flutter v3.19.0. I probably need to specify this restriction in the SDK, need to double-check. Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants