Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for localization #62

Merged
merged 4 commits into from Mar 3, 2024

Conversation

chooyan-eng
Copy link
Contributor

@chooyan-eng chooyan-eng commented Mar 2, 2024

Status

READY

Description

Added support for localization of slides by bypassing MaterialApp's parameters for localization.

This would be useful for those (like me) who originally made a slide in a non-English language, Japanese for instance, and want to share it globally with the same URL.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

References

https://docs.flutter.dev/ui/accessibility-and-internationalization/internationalization

Copy link
Owner

@mkobuolys mkobuolys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just some minor adjustments to documentation are needed.
Also, do not forget to update the CHANGELOG.md file, like:

# Next

- feat: add support for slide deck localization

@chooyan-eng
Copy link
Contributor Author

@mkobuolys Thank you for reviewing! I've fixed both of them.

@mkobuolys mkobuolys changed the title Added support for localization feat: added support for localization Mar 3, 2024
Copy link
Owner

@mkobuolys mkobuolys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Today I will try to add a control to change the slide deck's language at run-time, update the docs, and example. It will be released with v0.12.0 ASAP.

@mkobuolys mkobuolys merged commit f78639e into mkobuolys:main Mar 3, 2024
3 checks passed
@chooyan-eng
Copy link
Contributor Author

@mkobuolys Big appreciation for merging! I'll use this when released as I have one slide deck I want to build with this feature (not in a hurry).

@mkobuolys
Copy link
Owner

Screen.Recording.2024-03-03.at.23.56.08.mov

It's almost there, probably coming out tomorrow. Let's keep it a secret for now 🤫

@chooyan-eng
Copy link
Contributor Author

The control looks so cool!

@chooyan-eng chooyan-eng deleted the feature/localization branch March 3, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants