Remove input.rawValue experiment

I decided to not move forward with this experiment here: whatwg/html#5257 (comment) Bug: 1126053 Change-Id: Ic6dd7446f14d38dc5f9f5b9538a9278c88528ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399119 Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#805053} GitOrigin-RevId: 153159b0b83f6ef670d2b329e526018043cd430a
mjfroman · Sep 8, 2020 · 3409be0 · 3409be0
1 parent 92d9e98
commit 3409be0
Show file tree

Hide file tree

Showing 12 changed files with 0 additions and 31 deletions.
diff --git a/blink/renderer/core/html/forms/html_input_element.cc b/blink/renderer/core/html/forms/html_input_element.cc
@@ -1112,10 +1112,6 @@ String HTMLInputElement::value() const {
   return g_empty_string;
 }
 
-String HTMLInputElement::rawValue() const {
-  return input_type_view_->RawValue();
-}
-
 String HTMLInputElement::ValueOrDefaultLabel() const {
   String value = this->value();
   if (!value.IsNull())

diff --git a/blink/renderer/core/html/forms/html_input_element.h b/blink/renderer/core/html/forms/html_input_element.h
@@ -155,8 +155,6 @@ class CORE_EXPORT HTMLInputElement
   bool IsValidValue(const String&) const;
   bool HasDirtyValue() const;
 
-  String rawValue() const;
-
   String SanitizeValue(const String&) const;
 
   String LocalizeValue(const String&) const;

diff --git a/blink/renderer/core/html/forms/html_input_element.idl b/blink/renderer/core/html/forms/html_input_element.idl
@@ -81,8 +81,6 @@ enum SelectionMode { "select", "start", "end", "preserve" };
 
     readonly attribute NodeList labels;
 
-    [RuntimeEnabled=InputElementRawValue] readonly attribute DOMString rawValue;
-
     void select();
     [RaisesException, ImplementedAs=selectionStartForBinding] attribute unsigned long? selectionStart;
     [RaisesException, ImplementedAs=selectionEndForBinding] attribute unsigned long? selectionEnd;

diff --git a/blink/renderer/core/html/forms/input_type_view.cc b/blink/renderer/core/html/forms/input_type_view.cc
@@ -212,8 +212,4 @@ void ClickHandlingState::Trace(Visitor* visitor) const {
   EventDispatchHandlingState::Trace(visitor);
 }
 
-String InputTypeView::RawValue() const {
-  return g_empty_string;
-}
-
 }  // namespace blink
diff --git a/blink/renderer/core/html/forms/input_type_view.h b/blink/renderer/core/html/forms/input_type_view.h
@@ -145,7 +145,6 @@ class CORE_EXPORT InputTypeView : public GarbageCollectedMixin {
   // Validation functions
   virtual bool HasBadInput() const;
 
-  virtual String RawValue() const;
   virtual wtf_size_t FocusedFieldIndex() const { return 0; }
 
  protected:

diff --git a/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.cc b/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.cc
@@ -703,10 +703,6 @@ AXObject* MultipleFieldsTemporalInputTypeView::PopupRootAXObject() {
   return nullptr;
 }
 
-String MultipleFieldsTemporalInputTypeView::RawValue() const {
-  return GetDateTimeEditElement()->innerText();
-}
-
 wtf_size_t MultipleFieldsTemporalInputTypeView::FocusedFieldIndex() const {
   return GetDateTimeEditElement()->FocusedFieldIndex();
 }

diff --git a/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.h b/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.h
@@ -56,8 +56,6 @@ class MultipleFieldsTemporalInputTypeView final
   ~MultipleFieldsTemporalInputTypeView() override;
   void Trace(Visitor*) const override;
 
-  String RawValue() const override;
-
   wtf_size_t FocusedFieldIndex() const override;
 
  private:

diff --git a/blink/renderer/core/html/forms/text_field_input_type.cc b/blink/renderer/core/html/forms/text_field_input_type.cc
@@ -593,8 +593,4 @@ void TextFieldInputType::SpinButtonDidReleaseMouseCapture(
     GetElement().DispatchFormControlChangeEvent();
 }
 
-String TextFieldInputType::RawValue() const {
-  return GetElement().InnerEditorElement()->innerText();
-}
-
 }  // namespace blink
diff --git a/blink/renderer/core/html/forms/text_field_input_type.h b/blink/renderer/core/html/forms/text_field_input_type.h
@@ -46,8 +46,6 @@ class TextFieldInputType : public InputType,
   void Trace(Visitor*) const override;
   using InputType::GetElement;
 
-  String RawValue() const override;
-
  protected:
   TextFieldInputType(HTMLInputElement&);
   ~TextFieldInputType() override;

diff --git a/blink/renderer/platform/runtime_enabled_features.json5 b/blink/renderer/platform/runtime_enabled_features.json5
@@ -938,10 +938,6 @@
       name: "InertAttribute",
       status: "experimental",
     },
-    {
-      name: "InputElementRawValue",
-      status: "experimental",
-    },
     {
       name: "InputMultipleFieldsUI",
       // No plan to support complex UI for date/time INPUT types on Android.

diff --git a/blink/web_tests/webexposed/element-instance-property-listing-expected.txt b/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
@@ -732,7 +732,6 @@ html element input
     property name
     property pattern
     property placeholder
-    property rawValue
     property readOnly
     property reportValidity
     property required

diff --git a/blink/web_tests/webexposed/global-interface-listing-expected.txt b/blink/web_tests/webexposed/global-interface-listing-expected.txt
@@ -3516,7 +3516,6 @@ interface HTMLInputElement : HTMLElement
     getter name
     getter pattern
     getter placeholder
-    getter rawValue
     getter readOnly
     getter required
     getter selectionDirection